try to reduce boilerplate #3422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No dice. That whole module is moving to the _api crate. If CI wasn't so damn slow today, it'd already be done. |
|
more interested in what you thought of the approach |
Codecov Report
@@ Coverage Diff @@
## master #3422 +/- ##
========================================
+ Coverage 79.7% 79.7% +<.1%
========================================
Files 146 146
Lines 23095 23095
========================================
+ Hits 18417 18424 +7
+ Misses 4678 4671 -7 |
|
Love the approach. It'll be a little harder than that across crates. Have you done the C-preprocessor equivalent of |
in another life (3 months ago)... will look at your polished config and budget for further inspiration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for discussion